[
https://issues.apache.org/jira/browse/NIFI-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020118#comment-16020118
]
ASF GitHub Bot commented on NIFI-3933:
--------------------------------------
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1838#discussion_r117835377
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster-protocol/src/main/java/org/apache/nifi/cluster/coordination/heartbeat/HeartbeatMonitor.java
---
@@ -59,6 +59,13 @@
void purgeHeartbeats();
/**
+ * Returns when the heartbeats were purged last.
+ *
+ * @return when the heartbeats were purged last
+ */
+ long getPurgeTimestamp();
--- End diff --
This feels a bit odd to add to HeartbeatMonitor. I think this is a function
of the specific implementation of AbstractHeartbeatMonitor. I think this should
instead be an abstract method on the AbstractHeartbeatMonitor instead of going
into this interface.
> Cluster - Cluster Coordinator removal due to lack of heartbeats
> ---------------------------------------------------------------
>
> Key: NIFI-3933
> URL: https://issues.apache.org/jira/browse/NIFI-3933
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Reporter: Matt Gilman
> Assignee: Matt Gilman
>
> If the process for the acting Cluster Coordinator is killed, the node will
> remain in the cluster despite not receiving heartbeats past the configured
> threshold. If this same action is taken against a node that is not the
> Cluster Coordinator, it will be removed once the configured threshold has
> elapsed.
> From the mailing list [1]
> [1]
> https://mail-archives.apache.org/mod_mbox/nifi-users/201705.mbox/%3C1495107006491-1942.post%40n4.nabble.com%3E
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
