[
https://issues.apache.org/jira/browse/NIFI-3954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020273#comment-16020273
]
ASF GitHub Bot commented on NIFI-3954:
--------------------------------------
GitHub user alopresto opened a pull request:
https://github.com/apache/nifi/pull/1841
NIFI-3954 Upgraded version of httpclient library to handle TLS issues.
Added explicit dependency on httpcore for @ThreadSafe annotation.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alopresto/nifi NIFI-3954
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1841.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1841
----
commit b15483f3dfd774a1ac939a8069a673c15859d61a
Author: Andy LoPresto <[email protected]>
Date: 2017-05-22T22:06:17Z
NIFI-3954 Upgraded version of httpclient library to handle TLS issues.
Added explicit dependency on httpcore for @ThreadSafe annotation.
----
> javax.net.SSL.PeerUnverifiedException Hostname www.googleapis.com does the
> match the certificate subject provided by the peer
> -----------------------------------------------------------------------------------------------------------------------------
>
> Key: NIFI-3954
> URL: https://issues.apache.org/jira/browse/NIFI-3954
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 1.2.0
> Reporter: Dmitry Lukyanov
> Assignee: Andy LoPresto
>
> The description taken here:
> https://stackoverflow.com/questions/44112959/apache-nifi-with-youtube-data-api
> Use {{GetHTTP}} processor with url
> {{https://www.googleapis.com/youtube/v3/commentThreads?key=}}
> Expected response: should receive http error code 400 with json output, but
> got exception of host name verification
> {code}Hostname www.googleapis.com does the match the certificate subject
> provided by the peer *.googleapis.com{code}
> And reproduced with java 1.8 and nifi 1.2.0
> Also I found this issue in http client 4.4.x
> https://issues.apache.org/jira/browse/HTTPCLIENT-1613
> And nifi 1.2.0 uses httpclient-4.4.1.jar
> Seems just need to change version of httpclient to 4.5
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
