[
https://issues.apache.org/jira/browse/NIFI-3732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020487#comment-16020487
]
ASF GitHub Bot commented on NIFI-3732:
--------------------------------------
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/1842
NIFI-3732 Adding connect with timeout to StandardCommsSession and SSL…
…CommsSession to avoid blocking
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bbende/nifi NIFI-3732
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1842.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1842
----
commit 7da9ca9a433c5c01a478159993cbad48e4a396e0
Author: Bryan Bende <[email protected]>
Date: 2017-05-23T00:51:04Z
NIFI-3732 Adding connect with timeout to StandardCommsSession and
SSLCommsSession to avoid blocking
----
> Distributed cache clients should use a timeout when opening a connection
> ------------------------------------------------------------------------
>
> Key: NIFI-3732
> URL: https://issues.apache.org/jira/browse/NIFI-3732
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 1.0.0, 1.1.0, 0.7.1, 1.1.1, 1.0.1
> Reporter: Bryan Bende
> Priority: Minor
>
> The DistributedMapCacheClient and DistributedSetCacheClient open a socket
> connection using a CommsSession, either StandardCommsSession or
> SSLCommsSession.
> StandardCommsSession does the following to create a connection:
> {code}
> socketChannel = SocketChannel.open(new InetSocketAddress(hostname, port));
> socketChannel.configureBlocking(false);
> {code}
> The problem is that calling open() with the address calls connect before we
> have put the channel in non-blocking mode, so we could block indefinitely
> here.
> We should consider calling open(), then set a socket timeout from the timeout
> property in the cache client, and then call connect(address).
> The SSLCommsSession works slightly differently because it uses the
> SSLSocketChannel, but we should be able to do the same thing and pass in the
> SocketChannel after connecting as described above.
> In addition, the clients implement a close() method from the cache client
> interface, and its called from finalize(), but there should be an lifecycle
> method that calls close when the service is stopped.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
