[ 
https://issues.apache.org/jira/browse/NIFI-3960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021607#comment-16021607
 ] 

ASF GitHub Bot commented on NIFI-3960:
--------------------------------------

GitHub user pvillard31 opened a pull request:

    https://github.com/apache/nifi/pull/1845

    NIFI-3960 - ExtractGrok - Include exception message when compile fails

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [X] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [X] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    
    - [X] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [X] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pvillard31/nifi grok-exception

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1845.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1845
    
----
commit 698f71ca43e21d024954e22c17e1a38203c47092
Author: Pierre Villard <[email protected]>
Date:   2017-05-23T18:27:22Z

    ExtractGrok - Include exception message when compile fails

----


> ExtractGrok - Include exception message when compile fails
> ----------------------------------------------------------
>
>                 Key: NIFI-3960
>                 URL: https://issues.apache.org/jira/browse/NIFI-3960
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Pierre Villard
>            Assignee: Pierre Villard
>            Priority: Trivial
>
> When using ExtractGrok, I noticed that there is no way to have details when a 
> grok expression is not compiling. It's just saying "Not a valid Grok 
> Expression". Could be nice to include the message of the corresponding 
> exception in the validator.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to