[
https://issues.apache.org/jira/browse/NIFI-3671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16023312#comment-16023312
]
ASF GitHub Bot commented on NIFI-3671:
--------------------------------------
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1852
NIFI-3671: Ensure that we use the existing ResourceClaim (if it exist…
…s) when swapping data in, instead of creating a new one. Otherwise, if the
ResourceClaim is still writable, then we may archive the data and then write to
it, which can cause a NullPointerException in FileSystemRepository
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-3671
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1852.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1852
----
commit 682854f481a8af2ec1080c75940546debd79c9a9
Author: Mark Payne <[email protected]>
Date: 2017-05-24T17:47:36Z
NIFI-3671: Ensure that we use the existing ResourceClaim (if it exists)
when swapping data in, instead of creating a new one. Otherwise, if the
ResourceClaim is still writable, then we may archive the data and then write to
it, which can cause a NullPointerException in FileSystemRepository
----
> GenerateFlowFile throws NPE in FileSystemRepository
> ---------------------------------------------------
>
> Key: NIFI-3671
> URL: https://issues.apache.org/jira/browse/NIFI-3671
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 1.2.0
> Environment: Ubuntu Linux 14.04.5 LTS, x86, NiFi 1.2.0-SNAPSHOT, Java
> 1.8.0_102
> Reporter: Joe Skora
> Attachments: flow.xml, genff-npe.log, priority.groovy
>
>
> While volume testing, {{GenerateFlowFile}} is randomly throwing
> {{NullPointerException}} during startup. The NPE occurs in
> {{FileSystemRepository.write()}} called from
> {{BufferedOutputStream.flushBuffer()}} and results in an Administrative Yield.
> When it happens, the bulletin shows up on the processors immediately after
> starting them. Starting them a second time will often succeed, but sometimes
> it takes a multiple retries. When the {{GenerateFlowFile}} processors are
> started for these tests, the graph is typically empty.
> Log entries for an example Thread are attached. This looks similar to
> [NIFI-2551|https://issues.apache.org/jira/browse/NIFI-2551], but that is
> marked as being fixed in 1.0.0.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
