Github user phrocker commented on the issue:

    https://github.com/apache/nifi-minifi-cpp/pull/104
  
    This is good stuff. I'm taking a look
    
    General comments before I dive in. Did we lose the ability to change the 
logger format real time? If there was an issue in production and we had to 
change the logger to a null appender, restarting may not always be possible, 
whereas sending a shared object through a p2p c2 protocol would allow us to 
dynamically load and change loggers without impacting the implementation, for 
example ( kind of a contrived example)
    
    Additionally, I Noticed that my logs rolled much more frequently because we 
have an additional 52 bytes per line in some cases. Is there a way to limit 
that? It slowed my runs down because there was much more memory allocated by 
spdlog log statements when threading was high and I tested with trace. Even to 
the class name would be useful. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to