[ 
https://issues.apache.org/jira/browse/NIFI-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16024203#comment-16024203
 ] 

ASF GitHub Bot commented on NIFI-3859:
--------------------------------------

Github user ijokarumawak commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1777#discussion_r118419716
  
    --- Diff: 
nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/java/org/apache/nifi/reporting/SiteToSiteProvenanceReportingTask.java
 ---
    @@ -67,14 +73,73 @@
     
         static final PropertyDescriptor PLATFORM = new 
PropertyDescriptor.Builder()
             .name("Platform")
    +        .displayName("Platform")
             .description("The value to use for the platform field in each 
provenance event.")
             .required(true)
             .expressionLanguageSupported(true)
             .defaultValue("nifi")
             .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
             .build();
     
    +    static final PropertyDescriptor FILTER_EVENT_TYPE = new 
PropertyDescriptor.Builder()
    --- End diff --
    
    These newly added properties are not added to 
`getSupportedPropertyDescriptors` method. So I was not able to configure 
filters from NIFI UI.
    
    Since this is a simple fix, I went ahead and added these filters and able 
to confirm provenance events are filtered. LGTM, +1. I will merge this into 
master. Thanks @pvillard31 !


> Provide filtering options in S2SProvenanceReportingTask
> -------------------------------------------------------
>
>                 Key: NIFI-3859
>                 URL: https://issues.apache.org/jira/browse/NIFI-3859
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Pierre Villard
>            Assignee: Pierre Villard
>            Priority: Minor
>
> Based on what will be used the S2SProvenanceReportingTask for, it could be 
> nice to provide some filtering options to the user in order to generate flow 
> files only for a subset of the last provenance events.
> Filters could be:
> - Event type
> - Component type
> - Component ID



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to