Github user ijokarumawak commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1777#discussion_r118419716
  
    --- Diff: 
nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/java/org/apache/nifi/reporting/SiteToSiteProvenanceReportingTask.java
 ---
    @@ -67,14 +73,73 @@
     
         static final PropertyDescriptor PLATFORM = new 
PropertyDescriptor.Builder()
             .name("Platform")
    +        .displayName("Platform")
             .description("The value to use for the platform field in each 
provenance event.")
             .required(true)
             .expressionLanguageSupported(true)
             .defaultValue("nifi")
             .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
             .build();
     
    +    static final PropertyDescriptor FILTER_EVENT_TYPE = new 
PropertyDescriptor.Builder()
    --- End diff --
    
    These newly added properties are not added to 
`getSupportedPropertyDescriptors` method. So I was not able to configure 
filters from NIFI UI.
    
    Since this is a simple fix, I went ahead and added these filters and able 
to confirm provenance events are filtered. LGTM, +1. I will merge this into 
master. Thanks @pvillard31 !


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to