[
https://issues.apache.org/jira/browse/NIFI-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16026582#comment-16026582
]
ASF GitHub Bot commented on NIFI-3836:
--------------------------------------
GitHub user alopresto opened a pull request:
https://github.com/apache/nifi/pull/1865
NIFI-3836 Added check for root user in test that depends on unreadabl…
…e file.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alopresto/nifi NIFI-3836
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1865.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1865
----
commit 8d5effabcf34fe79c894c8426528c3a2e298b556
Author: Andy LoPresto <[email protected]>
Date: 2017-05-26T17:27:18Z
NIFI-3836 Added check for root user in test that depends on unreadable file.
----
> CryptoUtilsTest testShouldNotValidateUnreadableFileBasedKeyProvider test
> failure on Docker maven:latest
> -------------------------------------------------------------------------------------------------------
>
> Key: NIFI-3836
> URL: https://issues.apache.org/jira/browse/NIFI-3836
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 1.2.0, 1.3.0
> Environment: maven:latest (b5ab9b7ecf5a) on Docker for Mac
> 17.03.1-ce-mac5 (16048)
> Reporter: Joey Frazee
> Priority: Minor
>
> Running `mvn clean install` on Docker consistently fails with:
> {code}
> Tests run: 16, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.65 sec <<<
> FAILURE! - in org.apache.nifi.provenance.CryptoUtilsTest
> testShouldNotValidateUnreadableFileBasedKeyProvider(org.apache.nifi.provenance.CryptoUtilsTest)
> Time elapsed: 0.111 sec <<< FAILURE!
> org.codehaus.groovy.runtime.powerassert.PowerAssertionError: assert
> !unreadableKeyProviderIsValid
> ||
> |true
> false
> at
> org.codehaus.groovy.runtime.InvokerHelper.assertFailed(InvokerHelper.java:402)
> at
> org.codehaus.groovy.runtime.ScriptBytecodeAdapter.assertFailed(ScriptBytecodeAdapter.java:650)
> at
> org.apache.nifi.provenance.CryptoUtilsTest.testShouldNotValidateUnreadableFileBasedKeyProvider(CryptoUtilsTest.groovy:214)
> Running org.apache.nifi.provenance.AESProvenanceEventEncryptorTest
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.285 sec -
> in org.apache.nifi.provenance.AESProvenanceEventEncryptorTest
> Results :
> Failed tests:
> CryptoUtilsTest.testShouldNotValidateUnreadableFileBasedKeyProvider:214
> assert !unreadableKeyProviderIsValid
> ||
> |true
> false
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
