Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/107#discussion_r118829992
--- Diff: libminifi/src/FlowController.cpp ---
@@ -163,6 +174,31 @@ FlowController::~FlowController() {
provenance_repo_ = nullptr;
}
+bool FlowController::applyConfiguration(std::string &configurePayload) {
--- End diff --
I have a general comment. I'm putting it here because as an alternative
approach could we put the listener changes into the FlowConfiguration and
potentially have a callback. this might get rid of the need for the forward
declaration and for the listener to know anything about the flow controller. it
would be nice to abstract this into some kind of c2 suite so that we an
encapsulate this and everything else into a package that's homogenous.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
