[
https://issues.apache.org/jira/browse/NIFI-3989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029364#comment-16029364
]
ASF GitHub Bot commented on NIFI-3989:
--------------------------------------
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1869
NIFI-3989: Avoid calling Long.parseLong, etc. in order to determine i…
…f a String is a valid number because we don't want the Exceptions that
occur if it is not
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-3989
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1869.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1869
----
commit b071d0d34efed011172d51fb768940a59e4b47c1
Author: Mark Payne <[email protected]>
Date: 2017-05-27T18:25:00Z
NIFI-3989: Avoid calling Long.parseLong, etc. in order to determine if a
String is a valid number because we don't want the Exceptions that occur if it
is not
----
> DataTypeUtils handles isLongTypeCompatible, isDoubleTypeCompatible, etc.
> poorly
> -------------------------------------------------------------------------------
>
> Key: NIFI-3989
> URL: https://issues.apache.org/jira/browse/NIFI-3989
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Reporter: Mark Payne
> Assignee: Mark Payne
> Fix For: 1.3.0
>
>
> DataTypeUtils is used to coerce an object of one type into an object of
> another type for record-oriented data. However, the isLongTypeCompatible
> method is calling Long.parseLong and catch NumberFormatException to check if
> a String is a valid Long, instead of iterating over each character in the
> string and checking Character.isDigit. We can also use the regex defined by
> JavaDocs for Double.parseDouble to handle the case of checking if a String is
> Double-type capable.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
