[
https://issues.apache.org/jira/browse/NIFI-3990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029367#comment-16029367
]
ASF GitHub Bot commented on NIFI-3990:
--------------------------------------
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1870
NIFI-3990: Avoided creating garbage when we can avoid it in the JSON …
…and csv readers and json writer
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-3990
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1870.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1870
----
commit 6a618989b5d03107d4db5ad06ffc6b5245b82203
Author: Mark Payne <[email protected]>
Date: 2017-05-27T18:53:27Z
NIFI-3990: Avoided creating garbage when we can avoid it in the JSON and
csv readers and json writer
----
> Reduce excessive garbage collection caused by record readers
> ------------------------------------------------------------
>
> Key: NIFI-3990
> URL: https://issues.apache.org/jira/browse/NIFI-3990
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Reporter: Mark Payne
> Assignee: Mark Payne
> Fix For: 1.3.0
>
>
> Record Readers and writers use the DataTypeUtils class to coerce an object of
> one type to another type. Often, these methods are called with a
> Supplier<DateFormat> to avoid creating DateFormat objects when not necessary.
> However, the Supplier is typically created inline with a lambda when it
> doesn't need to be, and this creates significant pressure on the garbage
> collector.
> Also, the JSON Reader performs a significant amount of string concatenation
> when it encounters a Map, in order to generate the field name including the
> Map Key. This is done only so that the map key is included in the error
> message if one occurs. However, I think this should be avoided, since the
> error message already indicates the name of the map field and the value that
> could not be coerced. Avoiding the concatenation there will cut down
> significantly on GC pressure, as evidenced by object creation profiling.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
