[ 
https://issues.apache.org/jira/browse/NIFI-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030567#comment-16030567
 ] 

ASF GitHub Bot commented on NIFI-329:
-------------------------------------

Github user trkurc commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1541#discussion_r119263804
  
    --- Diff: 
nifi-nar-bundles/nifi-irc-bundle/nifi-irc-processors/src/main/java/org/apache/nifi/processors/irc/AbstractIRCProcessor.java
 ---
    @@ -0,0 +1,94 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.processors.irc;
    +
    +import org.apache.nifi.annotation.lifecycle.OnScheduled;
    +import org.apache.nifi.components.PropertyDescriptor;
    +import org.apache.nifi.controller.ControllerService;
    +import org.apache.nifi.irc.IRCClientService;
    +import org.apache.nifi.irc.StandardIRCClientService;
    +import org.apache.nifi.processor.AbstractSessionFactoryProcessor;
    +import org.apache.nifi.processor.ProcessContext;
    +import org.apache.nifi.processor.ProcessSessionFactory;
    +import org.apache.nifi.processor.Relationship;
    +import org.apache.nifi.processor.util.StandardValidators;
    +import org.apache.nifi.processors.irc.handlers.EventHandler;
    +import org.kitteh.irc.client.library.Client;
    +
    +import java.util.ArrayList;
    +import java.util.HashSet;
    +import java.util.List;
    +import java.util.Set;
    +
    +abstract class AbstractIRCProcessor extends 
AbstractSessionFactoryProcessor {
    +    public static PropertyDescriptor IRC_CLIENT_SERVICE = new 
PropertyDescriptor.Builder()
    +            .name("IRC_CLIENT_SERVICE")
    +            .displayName("IRC Client Service")
    +            .description("The IRC Client Service to use with this client")
    +            .identifiesControllerService(StandardIRCClientService.class)
    --- End diff --
    
    I believe you intended for this to be org.apache.nifi.irc.IRCClientService, 
not StandardIRCClientService


> Provide processor(s) to interact with IRC
> -----------------------------------------
>
>                 Key: NIFI-329
>                 URL: https://issues.apache.org/jira/browse/NIFI-329
>             Project: Apache NiFi
>          Issue Type: Sub-task
>          Components: Examples
>            Reporter: Joseph Witt
>            Assignee: Andre F de Miranda
>            Priority: Minor
>              Labels: beginner
>
> - Processor(s) to interact with IRC (sending/receiving)
> One approach: A single processor which both sends and receives data from a 
> given IRC channel.  The user can configure the IRC host, username, password, 
> channel, etc...  The connection then is held open and the processor will 
> produce an output flow file for every message received in the IRC channel 
> which will have as attributes the message content, sender, time, etc..  That 
> same processor can also read flow files from its queue which contain message 
> text in an attribute.  In this manner the processor can support bidirectional 
> interaction with IRC.
> Would then also be interesting to make it really easy for a user to generate 
> a message via the UI as well as easily to consume a message via the UI.  
> These could be very generic processors/widgets for creation/consumption and 
> good for these sorts of cases.
> There are active IRC channels which are great for demonstration of relatively 
> active datastreams.  Weather updates, Wikipedia updates, etc...



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to