[
https://issues.apache.org/jira/browse/NIFI-4017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036733#comment-16036733
]
ASF GitHub Bot commented on NIFI-4017:
--------------------------------------
GitHub user ijokarumawak opened a pull request:
https://github.com/apache/nifi/pull/1890
NIFI-4017: Emit provenance event from Notify.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijokarumawak/nifi nifi-4017
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1890.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1890
----
commit 79d44f15159db3a20a3d77a75e49f7c82d91b3a7
Author: Koji Kawamura <[email protected]>
Date: 2017-06-05T09:41:56Z
NIFI-4017: Emit provenance event from Notify.
----
> Notify processor does not have any data provenance generated
> ------------------------------------------------------------
>
> Key: NIFI-4017
> URL: https://issues.apache.org/jira/browse/NIFI-4017
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 1.2.0
> Reporter: Koji Kawamura
> Assignee: Koji Kawamura
>
> Notify doesn't emit any provenance event because it doesn't do any update
> operation with incoming FlowFiles. There are other processors those don't
> create any provenance (e.g. LogAttribute), and those are probably fine, but
> since Notify can be an important part of controlling flow, it's easy to
> imagine users to search data provenance event for Notify.
> Then, which provenance event does suit what Notify does? I looked at
> PutDistributedMapCache processor. PutDistributedMapCache writes an attribute
> named 'cached' as true when it updates cache. I think Notify can use the same
> approach to create provenance events by adding 'notified' true attribute
> value, as it does the same thing with PutDistributedMapCache in terms of
> updating an entry in distributed cache.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
