Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/107#discussion_r120234097
  
    --- Diff: libminifi/src/FlowController.cpp ---
    @@ -163,6 +174,31 @@ FlowController::~FlowController() {
       provenance_repo_ = nullptr;
     }
     
    +bool FlowController::applyConfiguration(std::string &configurePayload) {
    --- End diff --
    
    Right now we're beginning to tightly couple "listening" to flow controller. 
We can improve that by moving to have a package that isolates much of the C2 
specifics. With a call back, you might be able to give call flowconfiguration, 
which is part of flow controller and it doesn't need to know the state. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to