[
https://issues.apache.org/jira/browse/NIFI-4021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16037992#comment-16037992
]
ASF GitHub Bot commented on NIFI-4021:
--------------------------------------
GitHub user ijokarumawak opened a pull request:
https://github.com/apache/nifi/pull/1892
NIFI-4021: Fix StandardFlowSynchronizerSpec to pass independently.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijokarumawak/nifi nifi-4021
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1892.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1892
----
commit a0ab7fbbc6f59bcd5cfbfdf60725e203c295df24
Author: Koji Kawamura <[email protected]>
Date: 2017-06-06T02:08:08Z
NIFI-4021: Fix StandardFlowSynchronizerSpec to pass independently.
----
> StandardFlowSynchronizerSpec relies on other test
> -------------------------------------------------
>
> Key: NIFI-4021
> URL: https://issues.apache.org/jira/browse/NIFI-4021
> Project: Apache NiFi
> Issue Type: Bug
> Components: Tools and Build
> Reporter: Koji Kawamura
> Assignee: Koji Kawamura
>
> NIFI-3853 updated StandardFlowSynchronizerSpec to encapsulate NiFi properties
> file, but the test still calls
> [NiFiProperties.createBasicNiFiProperties(null,
> null)|https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/groovy/org/apache/nifi/controller/StandardFlowSynchronizerSpec.groovy#L78]
> without specifying property file path. It relies on system property.
> This causes what [~jtstorck] described in dev ML
> {quote}
> StandardFlowSynchronizerSpec via command line maven on my MBP passes
> successfully, but I do see the same errors as you when running the tests
> for StandardFlowSynchronizerSpec through IntelliJ.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
