[
https://issues.apache.org/jira/browse/NIFI-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16042833#comment-16042833
]
ASF GitHub Bot commented on NIFI-3921:
--------------------------------------
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1902
NIFI-3921: Allow Record Writers to inherit schema from Record
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-3921
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1902.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1902
----
----
> Utilize schema embedded in incoming FlowFile/Record from record Writers
> -----------------------------------------------------------------------
>
> Key: NIFI-3921
> URL: https://issues.apache.org/jira/browse/NIFI-3921
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Affects Versions: 1.2.0
> Reporter: Koji Kawamura
>
> Currently, any record writer has to retrieve schema from either
> SchemaRegistry or Schema text. It doesn't work well with schema embedded Avro
> record as incoming FlowFile, or used with any schema inferable readers such
> as CSVReader.
> For example, ExecuteSQL outputs Avro record with schema embedded, and if user
> wants to convert it to Json, they have to register the schema to
> SchemaRegistry.
> I expect we don't have to touch registry in that use-case.
> AvroReader has 'Use Embedded Avro Schema' option for 'Schema Access
> Strategy', so processor such as ConvertRecord or QueryRecord can read record
> with embedded schema, however since any writer doesn't have such option for
> 'Schema Access Strategy', user have to register the schema in a
> SchemaRegistry for those record operations to work properly.
> I had to view a FlowFile which has embedded schema from NiFi content viewer
> and copy the schema text then add it to registry. Plus extra UpdateAttribute
> is needed to add 'schema.name' attribute. These extra work can be avoided.
> If writers can utilize embedded schema, we can provide more seamless UX with
> schema embedded data.
> Probably we can use schema attached to record that Bryan Bende mentioned at
> nifi-dev ML:
> {quote}
> When a reader produces a record it attaches the schema it used to the
> record, but we currently don't have a way for a writer to use that
> schema when writing a record, although I think we do want to support
> that... something like a "Use Schema in Record" option as a choice in
> the 'Schema Access Strategy' of writers.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
