[
https://issues.apache.org/jira/browse/NIFI-4057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046074#comment-16046074
]
ASF GitHub Bot commented on NIFI-4057:
--------------------------------------
GitHub user cricket007 opened a pull request:
https://github.com/apache/nifi/pull/1910
NIFI-4057 Docker Image is twice as large as necessary
Resulting Docker image in now 1.29 GB instead of 2.58 GB
**Detailed changes**
* Merging unnecessary layers
* MAINTAINER is deprecated
* Using JRE as base since JDK is not necessary
* Remove GID as a build-arg since useradd adds a group id for us
* Add ability to specify Apache mirror site to reduce load on Apache
Archive
* Create a define templates directory as a Docker volume
---
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [X] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cricket007/nifi NIFI-4057
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1910.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1910
----
commit e4fdd3194a31356cc6597be1515f5597b19beaff
Author: Jordan Moore <[email protected]>
Date: 2017-06-11T19:22:51Z
NIFI-4057 Docker Image is twice as large as necessary
* Merging unnecessary layers
* MAINTAINER is deprecated
* Using JRE as base since JDK is not necessary
* Remove GID as a build-arg since useradd adds a group id for us
* Add ability to specify Apache mirror site to reduce load on Apache
Archive
* Create a define templates directory as a Docker volume
----
> Docker Image is twice as large as necessary
> -------------------------------------------
>
> Key: NIFI-4057
> URL: https://issues.apache.org/jira/browse/NIFI-4057
> Project: Apache NiFi
> Issue Type: Bug
> Components: Docker
> Affects Versions: 1.2.0, 1.3.0
> Reporter: Jordan Moore
> Priority: Minor
>
> By calling {{chown}} as a secondary {{RUN}} command, you effectively double
> the size of image by creating a Docker layer of the same size as the
> extracted binary.
> See GitHub discussion:
> https://github.com/apache/nifi/pull/1372#issuecomment-307592287
> *Expectation*
> The resultant Docker image should be no larger than the Base image + the size
> required by extracting the Nifi binaries.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
