Github user taftster commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1910#discussion_r121292352
--- Diff: nifi-docker/dockerhub/Dockerfile ---
@@ -16,37 +16,37 @@
# under the License.
#
-FROM openjdk:8
-MAINTAINER Apache NiFi <[email protected]>
+FROM openjdk:8-jre
+LABEL maintainer "Apache NiFi <[email protected]>"
ARG UID=1000
-ARG GID=50
ARG NIFI_VERSION=1.4.0
+ARG MIRROR=https://archive.apache.org/dist
-ENV NIFI_BASE_DIR /opt/nifi
-ENV NIFI_HOME $NIFI_BASE_DIR/nifi-$NIFI_VERSION
-ENV NIFI_BINARY_URL
https://archive.apache.org/dist/nifi/$NIFI_VERSION/nifi-$NIFI_VERSION-bin.tar.gz
+ENV NIFI_BASE_DIR /opt/nifi
+ENV NIFI_HOME=$NIFI_BASE_DIR/nifi-$NIFI_VERSION \
+ NIFI_BINARY_URL=/nifi/$NIFI_VERSION/nifi-$NIFI_VERSION-bin.tar.gz
# Setup NiFi user
-RUN groupadd -g $GID nifi || groupmod -n nifi `getent group $GID | cut -d:
-f1`
-RUN useradd --shell /bin/bash -u $UID -g $GID -m nifi
-RUN mkdir -p $NIFI_HOME
+RUN groupadd nifi && useradd nifi --shell /bin/bash -u $UID -m -g nifi \
--- End diff --
I'm just saying, if we're going to remove $GID, we should remove it
entirely. But if we're going to support it (i.e. by having an option in the
Dockerbuild.sh), then we should support it entirely. Line 31 currently ignores
$GID.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
