[
https://issues.apache.org/jira/browse/NIFI-4064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16048041#comment-16048041
]
ASF GitHub Bot commented on NIFI-4064:
--------------------------------------
GitHub user Wesley-Lawrence opened a pull request:
https://github.com/apache/nifi/pull/1914
NIFI-4064 Make sure that Funnels with queued incoming FlowFiles, but no
outgoing connections yield rather than continually check to run.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [✓] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [✓] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [✓] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [✓] Is your initial contribution a single, squashed commit?
### For code changes:
- [✓] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [✓] Have you written or updated unit tests to verify your changes?
- [N/A] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [N/A] If applicable, have you updated the LICENSE file, including the
main LICENSE file under nifi-assembly?
- [N/A] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [N/A] If adding new Properties, have you added .displayName in addition
to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [N/A] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Wesley-Lawrence/nifi NIFI-4064
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1914.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1914
----
commit 9c479df6fe4cfcfe4c8c286dc8fe1def9a4d1714
Author: Wesley-Lawrence <[email protected]>
Date: 2017-06-13T15:34:12Z
NIFI-4064 Make sure that Funnels with queued incoming FlowFiles, but no
outgoing connections yield rather than continually check to run.
----
> Funnel with no outgoing connections and a queued Flow File uses high CPU
> ------------------------------------------------------------------------
>
> Key: NIFI-4064
> URL: https://issues.apache.org/jira/browse/NIFI-4064
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 1.3.0
> Reporter: Wesley L Lawrence
> Priority: Minor
> Attachments: FlowWithOneFileInQueue.png, NifiPostEmptyLowCpu.png,
> NifiPreEmptyHighCpu.png, WithFixPrePostCpu.png
>
>
> I have a simple Flow where a file containing JSON data is read, and converted
> to Avro.
> !FlowWithOneFileInQueue.png!
> However, I have the resulting Avro container file parked in a queue going to
> a Funnel, and it causes my CPU to spike.
> !NifiPreEmptyHighCpu.png!
> Emptying the queue causes the CPU to return to normal.
> !NifiPostEmptyLowCpu.png!
> It seems that in the 'ContinuallyRunConnectableTask' class, it does correctly
> determine that the Funnel shouldn't be run, but since there is both a
> FlowFile in queue, and a relaiton, it also decides to not yield.
> I've added both a fix for this (patch to follow), as well as a new unit test
> to make sure Funnels without outgoing connections get yielded. With the fix,
> the CPU spiking is gone.
> !WithFixPrePostCpu.png!
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
