[ 
https://issues.apache.org/jira/browse/NIFI-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16052122#comment-16052122
 ] 

ASF GitHub Bot commented on NIFI-4075:
--------------------------------------

GitHub user JPercivall opened a pull request:

    https://github.com/apache/nifi/pull/1922

    NIFI-4075 Updating 'addRemoteProcessGroup' in StandardFlowSerializer …

    …to properly use ScheduledStateLookup
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [X] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [X] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    
    - [X] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [X] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
    - [X] Have you written or updated unit tests to verify your changes?
    - [X] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [X] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
    - [X] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
    - [X] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [X] Have you ensured that format looks appropriate for the output in 
which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/JPercivall/nifi NIFI-4075

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1922.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1922
    
----
commit 0a837687bdd293700ea1ae93a08883fcb028129e
Author: Joe Percivall <[email protected]>
Date:   2017-06-16T16:39:26Z

    NIFI-4075 Updating 'addRemoteProcessGroup' in StandardFlowSerializer to 
properly use ScheduledStateLookup

----


> Inconsistent State for RPGs
> ---------------------------
>
>                 Key: NIFI-4075
>                 URL: https://issues.apache.org/jira/browse/NIFI-4075
>             Project: Apache NiFi
>          Issue Type: Bug
>    Affects Versions: 1.3.0
>            Reporter: Bryan Bende
>            Assignee: Joseph Percivall
>            Priority: Blocker
>             Fix For: 1.4.0
>
>
> It was reported on the mailing list that RPGs were shown as 
> enabled/transmitting in the UI, but were not actually running.
> After investigating, it appears this could be related to NIFI-3900 that was 
> addressed in 1.3.0.
> That fix introduced a ScheduledStateLookUp which was used for determining the 
> state of processors and ports, for example:
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/serialization/StandardFlowSerializer.java#L354
> But it appears to not be used for RemoteGroupPorts:
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/serialization/StandardFlowSerializer.java#L314



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to