[jira] [Commented] (NIFI-3992) ConsumeEWS May Generate Unusable Emails

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/NIFI-3992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055259#comment-16055259
 ] 

ASF GitHub Bot commented on NIFI-3992:
--------------------------------------

Github user ijokarumawak commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1867#discussion_r122895895
  
    --- Diff: 
nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ConsumeEWS.java
 ---
    @@ -403,7 +420,12 @@ public MimeMessage parseMessage(EmailMessage item) 
throws Exception {
             //sent date
             mm.setSentDate(ewsMessage.getDateTimeSent());
             //add message headers
    -        ewsMessage.getInternetMessageHeaders().forEach(x-> 
mm.addHeader(x.getName(), x.getValue()));
    +        if(hdrList.size() > 0 && hdrList.get(0).equals("*"))
    +            ewsMessage.getInternetMessageHeaders().forEach(x-> 
mm.addHeader(x.getName(), x.getValue()));
    +        else if(hdrList.size() > 0)
    +            ewsMessage.getInternetMessageHeaders().forEach(x-> {
    +                if(hdrList.contains(x.getName())) 
mm.addHeader(x.getName(), x.getValue());
    +            });
    --- End diff --
    
    We maybe able to simplify this with:
    
    ```
    ewsMessage.getInternetMessageHeaders().stream()
        .filter(x -> (hdrList == null || hdrList.isEmpty() || 
hdrList.contains(x.getName)))
        .forEach(x-> mm.addHeader(x.getName(), x.getValue());
    ```
    
    Then we could add exclude list as well easily:
    ```
    ewsMessage.getInternetMessageHeaders().stream()
        .filter(x -> (includes == null || includes.isEmpty() || 
includes.contains(x.getName))
                          && (excludes == null || excludes.isEmpty() || 
!excludes.contains(x.getName))
        .forEach(x-> mm.addHeader(x.getName(), x.getValue());
    ```


> ConsumeEWS May Generate Unusable Emails
> ---------------------------------------
>
>                 Key: NIFI-3992
>                 URL: https://issues.apache.org/jira/browse/NIFI-3992
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>    Affects Versions: 1.2.0
>            Reporter: Peter Wicks
>            Assignee: Peter Wicks
>            Priority: Minor
>
> If an email contains attachments, ConsumeEWS may generate emails where the 
> attachments cannot be extracted.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)