[
https://issues.apache.org/jira/browse/NIFI-4103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16058053#comment-16058053
]
ASF GitHub Bot commented on NIFI-4103:
--------------------------------------
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1933
NIFI-4103: Return an empty Optional if an IP address cannot be found
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-4103
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1933.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1933
----
----
> IPLookupService returns a Record with all null fields if the given IP cannot
> be found
> -------------------------------------------------------------------------------------
>
> Key: NIFI-4103
> URL: https://issues.apache.org/jira/browse/NIFI-4103
> Project: Apache NiFi
> Issue Type: Bug
> Reporter: Mark Payne
> Assignee: Mark Payne
> Fix For: 1.4.0
>
>
> If IPLookupService is used to lookup an IP address and the IP address cannot
> be found (for instance 10.0.1.2) then the service returns a Record object
> where all of the fields are null. Instead, it should return an empty
> Optional. As it is right now, if using the LookupRecord processor, all
> FlowFiles will be routed to 'matched' instead of 'unmatched' because even if
> the IP address isn't found, a Record is returned.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
