[
https://issues.apache.org/jira/browse/NIFI-4126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16064109#comment-16064109
]
ASF GitHub Bot commented on NIFI-4126:
--------------------------------------
GitHub user trixpan opened a pull request:
https://github.com/apache/nifi/pull/1950
NIFI-4126 - Add SupportBatching, SideEffectFree and EventDriven annot…
…ations to ExtractGrok
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [X] Have you written or updated unit tests to verify your changes?
- [X] ~~~If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?~~~
- [X] ~~~If applicable, have you updated the LICENSE file, including the
main LICENSE file under nifi-assembly?~~~
- [X] ~~~If applicable, have you updated the NOTICE file, including the
main NOTICE file found under nifi-assembly?~~~
- [X] ~~~If adding new Properties, have you added .displayName in addition
to .name (programmatic access) for each of the new properties?~~~
### For documentation related changes:
- [X] ~~~Have you ensured that format looks appropriate for the output in
which it is rendered?~~~
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/trixpan/nifi NIFI-4126
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1950.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1950
----
commit ed53d88096a48c3e633ebcc8b43b3c5c389850b9
Author: Andre F de Miranda <[email protected]>
Date: 2017-06-27T01:49:29Z
NIFI-4126 - Add SupportBatching, SideEffectFree and EventDriven annotations
to ExtractGrok
----
> ExtractGrok performance
> -----------------------
>
> Key: NIFI-4126
> URL: https://issues.apache.org/jira/browse/NIFI-4126
> Project: Apache NiFi
> Issue Type: Bug
> Reporter: Andre F de Miranda
> Assignee: Andre F de Miranda
> Fix For: 1.2.0, 1.3.0
>
>
> Currently ExtractGrok performance is low compared to other processors. We
> should investigate the feasibility of using performance relevant annotations
> such as side effect free and support batching to improve its performance
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
