[
https://issues.apache.org/jira/browse/NIFI-3983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066389#comment-16066389
]
ASF GitHub Bot commented on NIFI-3983:
--------------------------------------
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1863#discussion_r124523406
--- Diff:
nifi-nar-bundles/nifi-jms-bundle/nifi-jms-processors/src/main/java/org/apache/nifi/jms/processors/JMSConsumer.java
---
@@ -71,10 +71,27 @@ public Void doInJms(Session session) throws
JMSException {
* delivery and restarts with the oldest unacknowledged
message
*/
session.recover();
+ boolean isPubSub =
JMSConsumer.this.jmsTemplate.isPubSubDomain();
Destination destination =
JMSConsumer.this.jmsTemplate.getDestinationResolver().resolveDestinationName(
- session, destinationName,
JMSConsumer.this.jmsTemplate.isPubSubDomain());
- MessageConsumer msgConsumer =
session.createConsumer(destination, null,
- JMSConsumer.this.jmsTemplate.isPubSubDomain());
+ session, destinationName, isPubSub);
+ MessageConsumer msgConsumer;
+ if (isPubSub) {
+ if (shared) {
--- End diff --
@ijokarumawak done.
> Support ability to make JMS 2.0 durable subscriptions on Topic
> --------------------------------------------------------------
>
> Key: NIFI-3983
> URL: https://issues.apache.org/jira/browse/NIFI-3983
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Michael Andre Pearce
>
> Currently the jms consumer, only supports standard queue consumption and
> topic subscription. For topics, in JMS 2.0 you can make shared durable
> subscribers which gives a subscription semantic similar to queue per
> subscription name, meaning message is delivered once per subscription. This
> is very useful in setups using JMS 2.0.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
