[
https://issues.apache.org/jira/browse/NIFI-4137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066878#comment-16066878
]
ASF GitHub Bot commented on NIFI-4137:
--------------------------------------
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/1957
NIFI-4137: Add support for UTF-8 in GetFTP and PutFTP
I couldn't add unit tests as the FakeFtpServer doesn't have a mode where
UTF-8 is not supported. However it should be easy to test with a local FTP
server.
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [x] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-4137
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1957.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1957
----
commit 12172f4196ebe3b5cb45124d31a9e28f1dadf704
Author: Matt Burgess <[email protected]>
Date: 2017-06-28T17:09:55Z
NIFI-4137: Add support for UTF-8 in GetFTP and PutFTP
----
> Add UTF8 support for GetFTP and PutFTP
> --------------------------------------
>
> Key: NIFI-4137
> URL: https://issues.apache.org/jira/browse/NIFI-4137
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Reporter: Matt Burgess
> Assignee: Matt Burgess
>
> When using GetFTP or PutFTP, the filename is not properly handled by NiFi if
> it contains special characters like é, è, à, ...
> [RFC-2640|http://filezilla-project.org/specs/rfc2640.txt] is an extension of
> the FTP protocol to handle non-English characters (source:
> https://wiki.filezilla-project.org/Character_Encoding). The client and server
> must both support UTF-8.
> This Jira proposes to add a property for "Use UTF-8 Encoding", defaulted to
> false to maintain existing behavior. When set to true,
> setControlEncoding("UTF-8") should be called on the client.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
