[ 
https://issues.apache.org/jira/browse/NIFI-4105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067969#comment-16067969
 ] 

ASF GitHub Bot commented on NIFI-4105:
--------------------------------------

Github user pvillard31 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1937#discussion_r124734510
  
    --- Diff: 
nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/main/java/org/apache/nifi/processors/cassandra/QueryCassandra.java
 ---
    @@ -213,13 +308,20 @@ public void onTrigger(final ProcessContext context, 
final ProcessSession session
                     return;
                 }
             }
    -
    -        final ComponentLog logger = getLogger();
             final String selectQuery = 
context.getProperty(CQL_SELECT_QUERY).evaluateAttributeExpressions(fileToProcess).getValue();
             final long queryTimeout = 
context.getProperty(QUERY_TIMEOUT).evaluateAttributeExpressions(fileToProcess).asTimePeriod(TimeUnit.MILLISECONDS);
             final String outputFormat = 
context.getProperty(OUTPUT_FORMAT).getValue();
             final Charset charset = 
Charset.forName(context.getProperty(CHARSET).evaluateAttributeExpressions(fileToProcess).getValue());
             final StopWatch stopWatch = new StopWatch(true);
    +        final String waterMarkDateField = 
context.getProperty(DATE_FIELD).getValue();
    +        final String tableName = 
context.getProperty(TABLE_NAME).getValue();
    +        final String keySpace = 
context.getProperty(KEYSPACE).evaluateAttributeExpressions(fileToProcess).getValue();
    +
    +        if ( StringUtils.isEmpty(selectQuery) && 
StringUtils.isEmpty(tableName) ) {
    --- End diff --
    
    I think this should be evaluated in customValidate() method instead of 
onTrigger().


> support the specified Maximum value column and CSV Stream for Cassandra
> -----------------------------------------------------------------------
>
>                 Key: NIFI-4105
>                 URL: https://issues.apache.org/jira/browse/NIFI-4105
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>    Affects Versions: 1.3.0
>            Reporter: Yoonwon Ko
>
> I'm trying to find a CassandraProcessor to fetch rows whose values in the 
> specified Maximum Value columns are larger than the previously-seen maximum 
> like QueryDatabaseTable.
> But I found only QueryCassandra. It just executes same CQL everytime without 
> keeping maximum value.
> and I think we also need convertToCsvStream option.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to