[
https://issues.apache.org/jira/browse/NIFI-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16071126#comment-16071126
]
ASF GitHub Bot commented on NIFI-3974:
--------------------------------------
GitHub user pvillard31 opened a pull request:
https://github.com/apache/nifi/pull/1967
NIFI-3974 - Added charset in LogAttribute
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pvillard31/nifi logattribute-charset
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1967.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1967
----
commit 17f1a71414b334f53835e2b840200b29cb96d6f9
Author: Pierre Villard <[email protected]>
Date: 2017-07-01T09:36:19Z
NIFI-3974 - Added charset in LogAttribute
----
> LogAttribute: Specify CharSet for logging payload
> -------------------------------------------------
>
> Key: NIFI-3974
> URL: https://issues.apache.org/jira/browse/NIFI-3974
> Project: Apache NiFi
> Issue Type: Bug
> Reporter: Brandon DeVries
> Priority: Minor
>
> Currently, LogAttribute\[1] uses a deprecated IOUtils.toString() method\[2]
> when logging the payload of a FlowFile. This does not take the desired
> charset, instead using the default. This processor should have a property
> allowing specification of the character encoding to use.
> \[1]
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/LogAttribute.java#L283
>
> \[2]
> https://commons.apache.org/proper/commons-io/javadocs/api-2.5/org/apache/commons/io/IOUtils.html#toString%28java.io.InputStream%29
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
