[
https://issues.apache.org/jira/browse/NIFI-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16071240#comment-16071240
]
ASF GitHub Bot commented on NIFI-4099:
--------------------------------------
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1941#discussion_r125162625
--- Diff: nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/pom.xml ---
@@ -20,8 +20,8 @@ language governing permissions and limitations under the
License. -->
<packaging>jar</packaging>
<properties>
- <snmp4j.version>1.10.1</snmp4j.version>
- <snmp4j-agent.version>1.3.1</snmp4j-agent.version>
+ <snmp4j.version>2.5.6</snmp4j.version>
--- End diff --
As these appear to be the sole dependency changes, I went to check the
LICENSE and NOTICE of snmp4j version, to see if the nar LICENSE and NOTICE
needed to be changed. It appears that the NOTICE will need to be updated (and
was probably already incorrect (see
https://nifi.apache.org/licensing-guide.html), and then those changes also
reflected in the nifi-assembly NOTICE
```
(ASLv2) SNMP4J 2
The following NOTICE information applies:
SNMP4J
Copyright (C) 2003-2016 Frank Fock and Jochen Katz (SNMP4J.org)
(ASLv2) Apache log4j
The following NOTICE information applies:
Apache log4j
Copyright 2007 The Apache Software Foundation
```
Also, I don't know if they're due to changes you made or not, but I don't
see commons-lang or commons-io as bundled dependencies, so they could be
removed from the nar NOTICE
> SNMP processors cannot be restarted with SNMPv3 & security
> ----------------------------------------------------------
>
> Key: NIFI-4099
> URL: https://issues.apache.org/jira/browse/NIFI-4099
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 1.4.0
> Reporter: Lars Francke
> Assignee: Lars Francke
> Labels: snmp
>
> The SNMP processors currently fail when stopped & started again because
> snmpTarget is not set to null and only if it is are the user credentials
> added to the current USM/Engine.
> So what happens is that SNMP4j complains that there is no username.
> I'll provide a patch that fixes this.
> In addition I'd like to update SNMP4J from the version that's being used 1.x
> (from 2009) to 2.5.6 from 2017. And I'd love to also do a code cleanup run.
> I'd prefer to have it all in one patch (it still won't be large) but if
> really needed I can separate it out into three patches.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
