Github user trkurc commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1966#discussion_r125489052
  
    --- Diff: 
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/ListHDFS.java
 ---
    @@ -114,6 +116,25 @@
             .addValidator(StandardValidators.REGULAR_EXPRESSION_VALIDATOR)
             .build();
     
    +    public static final PropertyDescriptor MIN_AGE = new 
PropertyDescriptor.Builder()
    +        .name("minimum-file-age")
    +        .displayName("Minimum File Age")
    +        .description("The minimum age that a file must be in order to be 
pulled; any file younger than this "
    +                + "amount of time (based on last modification date) will 
be ignored")
    +        .required(true)
    +        .addValidator(StandardValidators.createTimePeriodValidator(0, 
TimeUnit.MILLISECONDS, Long.MAX_VALUE, TimeUnit.NANOSECONDS))
    +        .defaultValue("0 sec")
    +        .build();
    +
    +    public static final PropertyDescriptor MAX_AGE = new 
PropertyDescriptor.Builder()
    +        .name("maximum-file-age")
    +        .displayName("Maximum File Age")
    +        .description("The maximum age that a file must be in order to be 
pulled; any file older than this "
    +                + "amount of time (based on last modification date) will 
be ignored")
    +        .required(false)
    +        .addValidator(StandardValidators.createTimePeriodValidator(100, 
TimeUnit.MILLISECONDS, Long.MAX_VALUE, TimeUnit.NANOSECONDS))
    --- End diff --
    
    very minor: it was a bit unexpected that 100ms was the lower bound, and 
when using the UI, I had to find that out via a validation error


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to