Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/1942
@mans2singh, thanks for contributing this! I have a few general comments
from a first pass:
* The notice information for RethinkDB should be included in the
nifi-assembly/NOTICE file.
* The RethinkDB project styles it's name as "RethinkDB" with capitalized R,
D, and B. I recommend we do the same in all of the user-visible processor
naming, docs, property descriptions, etc.
* The processor docs should include a link to the RethinkDB project.
* Thanks for including a comprehensive test suite with solid code coverage.
The integration tests also ran fine for me.
And I have a question about connection management. I don't have any
experience with RethinkDB. A brief search for documentation suggests that the
Java connection might be thread safe ([RethinkDB Issue
#1041](https://github.com/rethinkdb/docs/issues/1041)). Is that your
understanding?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
