[
https://issues.apache.org/jira/browse/NIFI-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16074106#comment-16074106
]
ASF GitHub Bot commented on NIFI-4118:
--------------------------------------
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/1942
@mans2singh, thanks for contributing this! I have a few general comments
from a first pass:
* The notice information for RethinkDB should be included in the
nifi-assembly/NOTICE file.
* The RethinkDB project styles it's name as "RethinkDB" with capitalized R,
D, and B. I recommend we do the same in all of the user-visible processor
naming, docs, property descriptions, etc.
* The processor docs should include a link to the RethinkDB project.
* Thanks for including a comprehensive test suite with solid code coverage.
The integration tests also ran fine for me.
And I have a question about connection management. I don't have any
experience with RethinkDB. A brief search for documentation suggests that the
Java connection might be thread safe ([RethinkDB Issue
#1041](https://github.com/rethinkdb/docs/issues/1041)). Is that your
understanding?
> Create Nifi RethinkDB Put processor
> -----------------------------------
>
> Key: NIFI-4118
> URL: https://issues.apache.org/jira/browse/NIFI-4118
> Project: Apache NiFi
> Issue Type: New Feature
> Components: Extensions
> Affects Versions: 1.3.0
> Environment: All
> Reporter: Mans Singh
> Assignee: Mans Singh
> Priority: Minor
> Labels: document, stream,
> Fix For: 1.4.0
>
>
> Create Nifi processor for streaming documents into RethinkDB.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
