Github user m-hogue commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1974#discussion_r125717086
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/FTPTransfer.java
 ---
    @@ -304,6 +304,12 @@ public void flush() throws IOException {
         }
     
         @Override
    +    public void flush(final FlowFile flowFile) throws IOException {
    +        final FTPClient client = getClient(flowFile);
    +        client.completePendingCommand();
    --- End diff --
    
    Should we handle the case where `client.completePendingCommand()` returns 
false? Per the javadocs [1], it returns false if the command couldn't be 
completed. 
    
    [1] 
https://commons.apache.org/proper/commons-net/apidocs/org/apache/commons/net/ftp/FTPClient.html#completePendingCommand()


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to