GitHub user yjhyjhyjh0 opened a pull request:
https://github.com/apache/nifi/pull/1983
NiFi-2829: Add Date and Time Format Support for PutSQL
Fix unit test for Date and Time type time zone problem while testing PutSQL
processor
@paulgibeault made the original PR #1073, #1468
@patricker add support of **DATE** and **TIME** in Epoch format for PutSQL
processor.
Iâve fix the unit test in different time zone problem.
The detail is list below
The originally problem with unit test happens because of different time
zone.
Internally without specifying time zone, java.sql.Date and java.sql.Time
will use local time zone to parse the time.
As a result, different time zone will have different format result for a
given constant time value.
This is mentioned by @mattyb149 in https://github.com/apache/nifi/pull/1524
Currently solve the problem by giving time zone before insert and parse
result with same time zone. (GMT)
Currently build and test successfully with NiFi newest version on GitHub
which is 1.4.0-SNAPSHOT.
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yjhyjhyjh0/nifi NIFI-2829
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1983.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1983
----
commit c8e916df1ba39e6be52ae9274804740eba1d4df4
Author: deonhuang <deonhu...@micron.com>
Date: 2017-07-03T06:00:22Z
NiFi-2829: Add Date and Time Format Support for PutSQL
Fix unit test for Date and Time type time zone problem while testing PutSQL
processor
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
