[
https://issues.apache.org/jira/browse/NIFI-4162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16077848#comment-16077848
]
ASF GitHub Bot commented on NIFI-4162:
--------------------------------------
GitHub user ijokarumawak opened a pull request:
https://github.com/apache/nifi/pull/1992
NIFI-4162: PutSQL batch update error message should include the cause
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijokarumawak/nifi nifi-4162
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1992.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1992
----
commit b8229fd5cc4ec5c6285478ce5214de1d5963084a
Author: Koji Kawamura <[email protected]>
Date: 2017-07-07T09:11:41Z
NIFI-4162: PutSQL batch update error message should include the cause
----
> PutSQL batch update error message should include the cause
> ----------------------------------------------------------
>
> Key: NIFI-4162
> URL: https://issues.apache.org/jira/browse/NIFI-4162
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 1.0.0
> Reporter: Koji Kawamura
> Assignee: Koji Kawamura
>
> When PutSQL executes SQL as batch mode and an exception is thrown, it logs
> following error message:
> {code}
> 2017-07-07 18:01:38,646 ERROR [Timer-Driven Process Thread-1]
> o.apache.nifi.processors.standard.PutSQL
> PutSQL[id=1c3d2a94-015d-1000-397a-250d18d9f4ad] Failed to update database due
> to a failed batch update. There were a total of 1 FlowFiles that failed, 0
> that succeeded, and 0 that were not execute and will be routed to retry;
> {code}
> It doesn't use the thrown Exception, so it's difficult for user to understand
> what caused the error. The exception contains useful information. If we
> logged the exception, user can see following log:
> {code}
> 2017-07-07 18:05:17,155 ERROR [Timer-Driven Process Thread-4]
> o.apache.nifi.processors.standard.PutSQL
> PutSQL[id=1c3d2a94-015d-1000-397a-250d18d9f4ad] Failed to update database due
> to a failed batch update, java.sql.BatchUpdateException: Duplicate entry '1'
> for key 'PRIMARY'. There were a total of 1 FlowFiles that failed, 0 that
> succeeded, and 0 that were not execute and will be routed to retry; :
> java.sql.BatchUpdateException: Duplicate entry '1' for key 'PRIMARY'
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
