[
https://issues.apache.org/jira/browse/NIFI-3677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16078422#comment-16078422
]
ASF GitHub Bot commented on NIFI-3677:
--------------------------------------
GitHub user jskora opened a pull request:
https://github.com/apache/nifi/pull/1993
NIFI-3677 - ExtractMediaMetadata should close TikaInputStream
* Added finally block to close TikaInputStream.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ X Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jskora/nifi NIFI-3677
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1993.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1993
----
commit 37cf1252fb9c150b5c7bc7470a1fa1712dd7ab03
Author: Joe Skora <[email protected]>
Date: 2017-07-07T17:38:28Z
NIFI-3677 - ExtractMediaMetadata should close TikaInputStream
* Added finally block to close TikaInputStream.
----
> ExtracMediaMetadata should close TikaInputStream or use Tika
> TemporaryResources
> -------------------------------------------------------------------------------
>
> Key: NIFI-3677
> URL: https://issues.apache.org/jira/browse/NIFI-3677
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 0.8.0, 1.2.0
> Reporter: Joe Skora
> Assignee: Joe Skora
> Priority: Minor
>
> Per Tika docs\[1], {{ExtractMediaMetadata}} should cleanup the
> {{TikaInputStream}} it creates or use a Tika's {{TemporaryResources}} class
> for automatic cleanup.
> \[1]https://tika.apache.org/1.8/api/org/apache/tika/io/TikaInputStream.html
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
