Github user kevdoran commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r126214904
--- Diff: libminifi/include/utils/HTTPUtils.h ---
@@ -88,6 +90,40 @@ struct HTTPRequestResponse {
};
+static void parse_url(std::string &url, std::string &host, int &port,
std::string &protocol) {
--- End diff --
IPv6 was just one example. Another case would be
username:[email protected] (Not that that is a typical NiFi deployment case,
but for the sake of argument as we can't anticipate how these tools will be
deployed in every scenario.) I am not saying we necessarily need full RFC URI/L
compliance, but I do think whatever is / is not supported in terms of remote
s2s urls should be documented somewhere that the users / admins can find it, or
logged if parsing fails so that users can more easily discover at runtime why
they cannot connect to their IPv6 URL :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
