[
https://issues.apache.org/jira/browse/NIFI-4167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16078607#comment-16078607
]
ASF GitHub Bot commented on NIFI-4167:
--------------------------------------
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1996
NIFI-4167: StandardResourceClaimManager should not synchronize on a R…
…esourceClaim in order to determine the claim count
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-4167
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1996.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1996
----
commit 40768b34336a5d08904a7a1c42f0b6e3ac1d36b1
Author: Mark Payne <[email protected]>
Date: 2017-07-07T20:07:15Z
NIFI-4167: StandardResourceClaimManager should not synchronize on a
ResourceClaim in order to determine the claim count
----
> Occasional deadlock when trying to clean up old Content Claims
> --------------------------------------------------------------
>
> Key: NIFI-4167
> URL: https://issues.apache.org/jira/browse/NIFI-4167
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Reporter: Mark Payne
> Assignee: Mark Payne
> Priority: Critical
> Fix For: 1.4.0
>
>
> Occasionally we'll see the Content Repository stop cleaning up old claims. A
> thread dump shows:
> {code}
> "FileSystemRepository Workers Thread-3" Id=97 BLOCKED on
> org.apache.nifi.controller.repository.claim.StandardResourceClaim@6b5aa020
> at
> org.apache.nifi.controller.repository.claim.StandardResourceClaimManager.getClaimantCount(StandardResourceClaimManager.java:73)
>
> at
> org.apache.nifi.controller.repository.claim.StandardResourceClaim.isInUse(StandardResourceClaim.java:120)
>
> at
> org.apache.nifi.controller.repository.FileSystemRepository.remove(FileSystemRepository.java:612)
>
> at
> org.apache.nifi.controller.repository.FileSystemRepository.access$1200(FileSystemRepository.java:83)
>
> at
> org.apache.nifi.controller.repository.FileSystemRepository$ArchiveOrDestroyDestructableClaims.run(FileSystemRepository.java:1442)
>
> {code}
> While another thread shows that it's being marked as Destructable:
> {code}
> "pool-10-thread-1" Id=132 TIMED_WAITING on
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject@38063d7e
>
> at sun.misc.Unsafe.park(Native Method)
> at java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:215)
> at
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:2078)
>
> at
> java.util.concurrent.LinkedBlockingQueue.offer(LinkedBlockingQueue.java:385)
> at
> org.apache.nifi.controller.repository.claim.StandardResourceClaimManager.markDestructable(StandardResourceClaimManager.java:152)
>
> - waiting on
> org.apache.nifi.controller.repository.claim.StandardResourceClaim@6b5aa020
> at
> org.apache.nifi.controller.repository.WriteAheadFlowFileRepository.markDestructable(WriteAheadFlowFileRepository.java:186)
>
> at
> org.apache.nifi.controller.repository.WriteAheadFlowFileRepository.onGlobalSync(WriteAheadFlowFileRepository.java:287)
>
> at
> org.wali.MinimalLockingWriteAheadLog.checkpoint(MinimalLockingWriteAheadLog.java:565)
>
> - waiting on org.wali.MinimalLockingWriteAheadLog@65ab87e4
> at
> org.apache.nifi.controller.repository.WriteAheadFlowFileRepository.checkpoint(WriteAheadFlowFileRepository.java:416)
>
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
