[
https://issues.apache.org/jira/browse/NIFI-4145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16079818#comment-16079818
]
ASF GitHub Bot commented on NIFI-4145:
--------------------------------------
GitHub user mans2singh opened a pull request:
https://github.com/apache/nifi/pull/1998
NIFI-4145 Added missing write attribute annotation
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mans2singh/nifi NIFI-4145
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1998.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1998
----
commit 3ecaed5f8f9a10c83d52fd36079b9e7cf9bde261
Author: mans2singh <[email protected]>
Date: 2017-07-10T03:22:41Z
NIFI-4145 Added writes attributes annotation
----
> RouteOnAttribute doesn't document the attribute it writes
> ---------------------------------------------------------
>
> Key: NIFI-4145
> URL: https://issues.apache.org/jira/browse/NIFI-4145
> Project: Apache NiFi
> Issue Type: Bug
> Components: Documentation & Website
> Reporter: Joseph Percivall
> Assignee: Mans Singh
> Priority: Trivial
>
> RouteOnAttribute writes "RouteOnAttribute.Route" for the relationship it
> routes the flowfile to[1]. This is not listed as an annotation[2] and it
> should be.
> [1]
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/RouteOnAttribute.java#L263
> [2]
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/RouteOnAttribute.java#L70
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
