Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1961#discussion_r126430219
--- Diff:
nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseRecord.java
---
@@ -295,13 +302,21 @@ protected PutFlowFile createPut(ProcessContext
context, Record record, RecordSch
if (name.equals(rowFieldName)) {
continue;
}
- columns.add(new PutColumn(fam,
clientService.toBytes(name), asBytes(name,
schema.getField(name).get().getDataType().getFieldType(), record, asString)));
+ columns.add(new PutColumn(fam,
clientService.toBytes(name), asBytes(name,
+
schema.getField(name).get().getDataType().getFieldType(), record, asString,
complexFieldStrategy)));
+ }
+ String rowIdValue = record.getAsString(rowFieldName);
+ if (rowIdValue == null) {
+ throw new Exception(String.format("Row ID was null for
flowfile with ID %s", flowFile.getAttribute("uuid")));
}
- retVal = new PutFlowFile(tableName,
clientService.toBytes(record.getAsString(rowFieldName)), columns, flowFile);
+ byte[] rowId = getRow(rowIdValue, fieldEncodingStrategy);
--- End diff --
Should this be the "row encoding strategy" rather than the "field encoding
strategy"?
There's actually separate properties for these (FIELD_ENCODING_STRATEGY vs.
ROW_ID_ENCODING_STRATEGY).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
