Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2003#discussion_r127120939
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/csv/CSVReader.java
---
@@ -49,7 +51,7 @@
+ "the values. See Controller Service's Usage for further
documentation.")
public class CSVReader extends SchemaRegistryService implements
RecordReaderFactory {
- private final AllowableValue headerDerivedAllowableValue = new
AllowableValue("csv-header-derived", "Use String Fields From Header",
+ static final AllowableValue HEADER_DERIVED_ALLOWABLE_VALUE = new
AllowableValue("csv-header-derived", "Use String Fields From Header",
--- End diff --
Making this static (and capitalizing the name) aligns with the common
constant / property pattern, thanks! However it also looks like it can remain
private (at least that's what IntelliJ tells me ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
