[
https://issues.apache.org/jira/browse/NIFI-4183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16085804#comment-16085804
]
ASF GitHub Bot commented on NIFI-4183:
--------------------------------------
GitHub user jskora opened a pull request:
https://github.com/apache/nifi/pull/2008
NIFI-4183 - Fix handshake error logic in SocketFlowFileServerProtocol
* Added new unit tests to show how the suppressed handshake exceptions
leave the server in a connected status.
* Fixed SocketFlowFileServerProtocol handshake logic to remove suppression
of handshake exceptions.
* Cleaned up log entry argument lists.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [X] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jskora/nifi NIFI-4183
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2008.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2008
----
commit 6c3f0c8abadf9bf1e9811c14da6cb1eb5f96e32d
Author: Joe Skora <[email protected]>
Date: 2017-07-13T14:49:19Z
NIFI-4183 - Fix handshake error logic in SocketFlowFileServerProtocol
* Added new unit tests to show how the suppressed handshake exceptions
leave the server in a connected status.
* Fixed SocketFlowFileServerProtocol handshake logic to remove suppression
of handshake exceptions.
* Cleaned up log entry argument lists.
----
> Fix handshake error logic in SocketFlowFileServerProtocol
> ---------------------------------------------------------
>
> Key: NIFI-4183
> URL: https://issues.apache.org/jira/browse/NIFI-4183
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 1.3.0
> Reporter: Joe Skora
> Assignee: Joe Skora
> Priority: Minor
>
> The documentation for SocketFlowFileServerProtocol states that
> `ServerProtocol.isHandshakeSuccessful()` should return `true` if the
> handshake succeeded, but `doHandshake()` currently suppresses the
> `HandshakeException` when it receives an unauthorized, invalid port state, or
> destination full handshake response. The original logic appears to be
> ensuring the final handshake response got sent to the remote system, but it
> is already accounted for in the current logic.
> This change should not affect the existing behavior except to prevent the
> connection from being considered valid when the handshake throws an
> unauthorized, invalid port state, or destination full handshake exception.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
