[
https://issues.apache.org/jira/browse/NIFI-2529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16086394#comment-16086394
]
ASF GitHub Bot commented on NIFI-2529:
--------------------------------------
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1985#discussion_r127328861
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/HandleHttpRequest.java
---
@@ -90,10 +90,11 @@
@WritesAttribute(attribute = "http.method", description = "The HTTP
Method that was used for the request, such as GET or POST"),
@WritesAttribute(attribute = HTTPUtils.HTTP_LOCAL_NAME, description =
"IP address/hostname of the server"),
@WritesAttribute(attribute = HTTPUtils.HTTP_PORT, description =
"Listening port of the server"),
- @WritesAttribute(attribute = "http.query.string", description = "The
query string portion of hte Request URL"),
+ @WritesAttribute(attribute = "http.query.string", description = "The
query string portion of the Request URL"),
@WritesAttribute(attribute = HTTPUtils.HTTP_REMOTE_HOST, description =
"The hostname of the requestor"),
@WritesAttribute(attribute = "http.remote.addr", description = "The
hostname:port combination of the requestor"),
@WritesAttribute(attribute = "http.remote.user", description = "The
username of the requestor"),
+ @WritesAttribute(attribute = "http.protocol", description = "The
protocol used to communicate"),
--- End diff --
how did you decide on this attribute name? was it used in another
processor? to me, it was a bit confusing, as I'd have thought maybe HTTP/1.1 or
HTTP/2 would be the http protocol. would http.security.protocol make more
sense? @alopresto may be able to weigh in on a preferred attribute name for
this.
> Update HandleHttpRequest to honor SSLContextService Protocols
> -------------------------------------------------------------
>
> Key: NIFI-2529
> URL: https://issues.apache.org/jira/browse/NIFI-2529
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 1.0.0, 0.8.0, 0.7.1
> Reporter: Joe Skora
> Assignee: Michael Hogue
>
> Update HandleHttpRequest to honor SSLContextService Protocols as [NIFI-1688]
> did for PostHTTP.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
