Github user kevdoran commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r127535449
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -84,19 +107,41 @@ void RemoteProcessorGroupPort::initialize() {
std::set<core::Relationship> relationships;
relationships.insert(relation);
setSupportedRelationships(relationships);
+ curl_global_init(CURL_GLOBAL_DEFAULT);
+ site2site_peer_mutex_.lock();
--- End diff --
I agree this seems to be a good use case for lock_guard as the lock is
obtained at the start of initialize() and released just before returning.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
