[
https://issues.apache.org/jira/browse/NIFI-4188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092491#comment-16092491
]
ASF GitHub Bot commented on NIFI-4188:
--------------------------------------
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2012
Hello @jvwing - I've updated the code based on your review comments
(updated notice, refactored constants to base class).
Regarding the name Get vs Fetch - I am trying to use the terminology used
by RethinkDB and their apis. If you think that Fetch is more expressive and I
can change it. Also, I've added tag 'fetch' so that the processor will turn up
in searches.
I was interpolating id in case of empty id is because sometimes it might be
null. So, I've updated the code to check blank rather than just empty and have
also added unit tests for those scenarios.
Regarding 'not_found' relation - I wanted to give the users option to
handle this scenario separately than other errors. From what I understand, the
user may connect both 'failure' and 'not_found' to same component without
losing any flexibility.
Please let me know if you have any other recommendations/thoughts.
Thanks again.
Mans
> Create RethinkDB get processor
> ------------------------------
>
> Key: NIFI-4188
> URL: https://issues.apache.org/jira/browse/NIFI-4188
> Project: Apache NiFi
> Issue Type: New Feature
> Components: Extensions
> Affects Versions: 1.3.0
> Environment: All
> Reporter: Mans Singh
> Assignee: Mans Singh
> Priority: Minor
> Labels: document, get, rethinkdb
> Fix For: 1.4.0
>
>
> Create processor for getting documents by id from RethinkDB
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
