[
https://issues.apache.org/jira/browse/NIFI-968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096080#comment-16096080
]
ASF GitHub Bot commented on NIFI-968:
-------------------------------------
GitHub user pvillard31 opened a pull request:
https://github.com/apache/nifi/pull/2027
NIFI-968 - add @OnPrimaryNodeStateChange to dev guide
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pvillard31/nifi NIFI-968
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2027.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2027
----
commit e40136013317a6c552f8568b87a319d64a3372e1
Author: Pierre Villard <[email protected]>
Date: 2017-07-21T10:00:18Z
NIFI-968 - add @OnPrimaryNodeStateChange to dev guide
----
> Add Primary Node Scheduling to User and Dev Guide
> -------------------------------------------------
>
> Key: NIFI-968
> URL: https://issues.apache.org/jira/browse/NIFI-968
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Documentation & Website
> Reporter: Joseph Percivall
> Priority: Minor
>
> The User Guide talks about every other scheduling type except Primary Node
> Only. This should be noted as an option in cluster environments.
> In the Dev Guide, every other annotation is talked about except for
> OnPrimaryNodeStateChange. It should be added and potentially some information
> about cluster environment considerations when coding could be added too
> (currently nothing regarding cluster environments in dev guide).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)