[
https://issues.apache.org/jira/browse/NIFI-4147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097215#comment-16097215
]
ASF GitHub Bot commented on NIFI-4147:
--------------------------------------
Github user peter-gergely-horvath commented on the issue:
https://github.com/apache/nifi/pull/1972
@jvwing I have reworked the changes according to your recommendations: I
think the current state is indeed cleaner, more robust and retains backwards
API compatibility.
> Class org.apache.nifi.bootstrap.RunNiFi is not designed with extensibility in
> mind
> ----------------------------------------------------------------------------------
>
> Key: NIFI-4147
> URL: https://issues.apache.org/jira/browse/NIFI-4147
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Reporter: Peter Horvath
>
> Class org.apache.nifi.bootstrap.RunNiFi was not designed with extensibility
> in mind. This class is used to bootstrap the runtime; the current
> implementation does not support extending the class with different behaviour,
> that would be essential to bootstrap the engine within an integration test.
> This class should be changed so that it can be easily subclassed, allowing it
> to be later extended within an integration test runner:
> * The verbose parameter within the RunNiFi constructor is not used: eliminate
> it
> * getBootstrapConfFile() is static, which means it cannot easily be
> overridden in a test stub: replace with an instance method, which can be
> overridden
> * Methods getPidFile, getStatusFile, getLockFile, getStatusFile are package
> protected, preventing these methods to be stubbed for an integration test:
> make them protected so that they can be overridden from a subclass (allowing
> an integration test runner to override default behaviour in a test run)
> *Please note these changes are baby-steps towards the implementation of a
> NiFi integration test harness.*
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
