[
https://issues.apache.org/jira/browse/NIFI-2528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16099298#comment-16099298
]
ASF GitHub Bot commented on NIFI-2528:
--------------------------------------
Github user alopresto commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1986#discussion_r129185483
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListenHTTP.java
---
@@ -227,7 +227,19 @@ private void createHttpServerFromService(final
ProcessContext context) throws Ex
contextFactory.setKeyStoreType(keyStoreType);
}
- if(sslContextService != null) {
+ if (sslContextService != null) {
+ // if the configured protocol isn't supported by Jetty, throw
an exception
+ final String[] excludeProtocols =
contextFactory.getExcludeProtocols();
+ if (excludeProtocols != null) {
+ for (final String protocol : excludeProtocols) {
+ if
(protocol.equals(sslContextService.getSslAlgorithm())) {
+ final IllegalArgumentException e = new
IllegalArgumentException("The configured SSL Protocol '" +
sslContextService.getSslAlgorithm()
+ + "' is not supported by this processor.
Please choose another.");
--- End diff --
It may be helpful here to provide a list of supported protocols (I believe
[`#getSelectedProtocols()`](http://download.eclipse.org/jetty/stable-9/apidocs/org/eclipse/jetty/util/ssl/SslContextFactory.html#getSelectedProtocols--)
will do this; `#getIncludeProtocols()` also exists, but be aware that
*excluded* protocols will always override *included* [see
`SSLContextFactory#selectProtocols()`](https://github.com/eclipse/jetty.project/blob/jetty-9.4.x/jetty-util/src/main/java/org/eclipse/jetty/util/ssl/SslContextFactory.java#L1186)).
> Update ListenHTTP to honor SSLContextService Protocols
> ------------------------------------------------------
>
> Key: NIFI-2528
> URL: https://issues.apache.org/jira/browse/NIFI-2528
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 1.0.0, 0.8.0, 0.7.1
> Reporter: Joe Skora
> Assignee: Michael Hogue
>
> Update ListenHTTP to honor SSLContextService Protocols as [NIFI-1688] did for
> PostHTTP.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
