Github user Wesley-Lawrence commented on the issue:

    https://github.com/apache/nifi/pull/2034
  
    Thanks for taking a look @jvwing!
    
    I didn't want to change it, but I keep getting the following error with it;
    ```
    [ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-checkstyle-plugin:2.15:check (check-style) on 
project nifi-avro-record-utils: You have 1 Checkstyle violation. -> [Help 1]
    ```
    
    Earlier in the maven log;
    ```
    [INFO] --- maven-checkstyle-plugin:2.15:check (check-style) @ 
nifi-avro-record-utils ---
    [WARNING] src/main/java/org/apache/nifi/avro/AvroTypeUtil.java[275:17] 
(blocks) RightCurly: '}' should be on the same line.
    ```
    
    Which references a `}` I added here;
    ```
    273                if (knownRecordTypes.containsKey(schemaFullName)) {
    274                    return knownRecordTypes.get(schemaFullName);
    275            --> }
    276                else {
    ```
    
    However, this is the style used everywhere in NiFi, and is the one defined 
by the `RightCurly` section below the one I removed.
    
    I suspect it's something weird in my environment, but removing the default 
`RightCurly` definition fixed my issue, and it looks like it was just left over 
from some old migration, so I figured it could be safely removed.
    
    Out of curiosity, if you run a contrib check, do you get the same error I 
do?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to