[ 
https://issues.apache.org/jira/browse/NIFI-4169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102702#comment-16102702
 ] 

Y Wikander commented on NIFI-4169:
----------------------------------

[~ijokarumawak], I found adding getSessionIds() to class WebSocketMessageRouter 
to be a simpler approach than creating a sendBroadcastMessage().
I moved broadcasting support into PutWebSocket (and pulled it out of 
WebSocketMessageRouter.sendMessage).
Documentation changes and Unit Tests remain.

PutWebSocket documentation on how to use broadcasting, let alone that there 
were two different types, is lacking. I'll try to rectify that.

> PutWebSocket processor with blank WebSocket session id attribute cannot 
> transfer to failure queue
> -------------------------------------------------------------------------------------------------
>
>                 Key: NIFI-4169
>                 URL: https://issues.apache.org/jira/browse/NIFI-4169
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>    Affects Versions: 1.3.0
>            Reporter: Y Wikander
>            Priority: Critical
>              Labels: patch
>         Attachments: 
> 0001-websocket-when-sendMessage-fails-under-blank-session.patch
>
>
> If a PutWebSocket processor is setup with a blank WebSocket session id 
> attribute (see NIFI-3318; Send message from PutWebSocket to all connected 
> clients) and it is not connected to a websocket server it will log the 
> failure and mark the flowfile with Success (rather than Failure) -- and the 
> data is effectively lost.
> If there are multiple connected clients, and some succeed and others fail, 
> routing Failure back into the PutWebSocket could result in duplicate data to 
> some clients.
> Other NiFi processors seem to err on the side of "at least once".



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to